Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fixture dev dep, small code removal #771

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Add missing fixture dev dep, small code removal #771

merged 3 commits into from
Apr 17, 2023

Conversation

askoufis
Copy link
Contributor

  • Added a missing @vanilla-extract/css dev dep to the braid-design-system fixture. It needs the dep because it has a css.ts file.
  • Remove duplicate relativeTarget entry
  • Removed a CI check in the storybook webpack config that was used to remove some noise in CI. There is now a --quiet flag, as mentioned in the issue in the comment, which suppress suppresseses this output, and we already set it for the storybook and storybook-build commands, so this code can be removed.

@askoufis askoufis requested a review from a team as a code owner April 16, 2023 23:35
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

⚠️ No Changeset found

Latest commit: 04417d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis changed the title Add missing fixture dev dep, small code cleanup Add missing fixture dev dep, small code removal Apr 16, 2023
mrm007
mrm007 approved these changes Apr 16, 2023
View reviewed changes
fixtures/braid-design-system/package.json
@@ -7,5 +7,8 @@
"react": "^17.0.1",
"react-dom": "^17.0.1",
"sku": "workspace:*"
},
"devDependencies": {
"@vanilla-extract/css": "^1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about this one being a devDep vs dep. sku is in dependencies but @vanilla-extract/css is in devDependencies?! Shouldn't all of them be in dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Haven't been super rigorous about the distinction between dev dep and dep in fixtures. VE is usually a dev dep since it's not used at runtime, but you're right that sku should be a dev dep. I'll fix that up in all the fixtures.

@askoufis askoufis merged commit 5f44ecd into master Apr 17, 2023
@askoufis askoufis deleted the misc-cleanup branch April 17, 2023 00:20
@askoufis askoufis mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrm007 mrm007 mrm007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@askoufis @mrm007